Fix bug with multiple GOPATH full package name resolving #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind throwing a test on it? |
|
Sure no problem, do you have some advice on how to mock/control |
|
It looks like its public, can you set it? 😈 |
|
If you're about pop into https://gitter.im/gqlgen/Lobby |
This commit fixes the bug where GOPATH values that are longer than the input package name cause 'slice bounds out of range' errors.
|
I hit this issue today trying to vendor this with retool. I would love this give this library a try, but I'm kind of stuck. Any chance this could be merged and released as |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Fix bug with multiple GOPATH full package name resolving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug where GOPATH values that are longer than the input package name cause 'slice bounds out of range' errors.