-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for graphql-transport-ws with duplex ping-pong #1578
Conversation
e99344b
to
e2704d5
Compare
@zdraganov did you make any substantive changes to #1507, or did you just extend it? It might be nice to merge the other first so I can review the extension in isolation. |
@zdraganov I rebased and squash merged #1507. If you could rebase yours (and add that comment mentioned in #1507 ) I would appreciate it very much. Thanks! |
ba62201
to
cc16324
Compare
cc16324
to
739de31
Compare
Rebased with the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good! Could you add a test or two to websocket_test.go
?
So when I run this:
I get this:
And as a result, I then when I run this:
I get a lot of failures which I assume are related. Sorry if I missed that when Jared and I reviewed it earlier (although maybe it's a new problem). Can you please take a look a this so we can get this merged? Thanks! |
a38d175
to
09f97c8
Compare
Fixed the test, but the generation problem doesn't happens on my side - BigSlur M1 |
Huh, well it didn't happen when I refreshed everything and tried it again, so maybe I was on some other branch and they merged weird. Thanks! |
(It would also be nice to have a test that is "client/server shuts down if pong isn't received within time limit") |
Extending this PR, included also the duplex ping-pong functionality.
How to use:
Example Apollo client usage: