Support interface unexported methods #169
Conversation
dvic
force-pushed
the
interface-unexported-methods
branch
from
dc69352
to
455343c
Compare
|
Build was failing due to linting false positive, I had to add |
|
I don't think there is enough here to justify a new example. Maybe just throw a test into something along the lines of https://github.com/vektah/gqlgen/blob/master/codegen/input_test.go#L35-L49? |
dvic
force-pushed
the
interface-unexported-methods
branch
2 times, most recently
from
64ec6b8
to
8c6d837
Compare
|
@vektah sorry it took so long, I rebased and pushed again but this time without the example and with the testing approach you suggested. In order to properly test this I had to replace the |
dvic
force-pushed
the
interface-unexported-methods
branch
from
8c6d837
to
147ba3c
Compare
dvic
force-pushed
the
interface-unexported-methods
branch
from
147ba3c
to
47c26d0
Compare
|
@vektah I updated the PR for 0.4.x. It seems that the interface types tests were removed? (while the test models were still defined). Not sure what you want to do with them, so for now I just added the tests back (with the updated |
|
All the tests that arent checking errors were moved into codegen/testserver those tests were taking way too long to run. I added some notes on testing - https://github.com/99designs/gqlgen/blob/master/TESTING.md |
| @@ -41,3 +41,26 @@ func TestGenerateServer(t *testing.T) { | |||
| _, err = conf.Load() | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| func generate(name string, schema string, typemap ...TypeMap) error { | |||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestShapes(t *testing.T) { |
There was a problem hiding this comment.
| "Foo": {Model: "github.com/99designs/gqlgen/codegen/testserver.IfaceFoo"}, | ||
| }) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, "", buf.String(), "using an interface with unexported methods should not emit warnings") |
There was a problem hiding this comment.
rather than test for the absence of a warning, could you look to see if a resolver was generated?
eg https://github.com/99designs/gqlgen/blob/master/codegen/testserver/generated_test.go#L24-L28
|
This change has been rolled into #335 |
I like to use unexported methods with interfaces to create union types in Go. This PR fixes the "missing method" warning. It replaces the original calls to
findMethodwithfindExportedMethod(which has the same logic).