Entity resolver tests #1697
Merged
Entity resolver tests #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCastillo
commented
Nov 8, 2021
| } | ||
| switch typeName { | ||
| case "Hello": | ||
| entity, err := func() (*generated.Hello, error) { |
There was a problem hiding this comment.
This generated.Hello is one bug where we include generated.
MiguelCastillo
commented
Nov 8, 2021
|
|
||
| case "World": | ||
| entity, err := func() (*generated.World, error) { | ||
| id0, err := ec.unmarshalNString2string(ctx, rep["hello"].(map[string]interface{})["name"]) |
There was a problem hiding this comment.
This is another bug if the entity query is for the key bar then this will throw an error.
|
@vektah these are the tests. I think I may be able to fix the couple of issues I mentioned here some time later today or tomorrow, so sadly these tests are going to be failing until then. |
Reorganizing the tests in the federation plugin a little bit so make it simpler to add more safely without testdata colliding. This is in anticipation for a follow up PR for adding entity resolver tests. Run the tests with `go test ./plugin/federation/...` and verify they all pass. Also verify that the testdata/allthething directory has a `generated` directory specific to that test. NOTE: There is a catch all type of test that I moved to the directory `allthething`. Open to suggestions for a better name! One potential thing to considere here is to split up the tests that use that testdata and break them down into more specific tests. E.g. Add a multikey test in the testdata/entity. For now, Im leaving that as a TODO.
MiguelCastillo
force-pushed
the
entity-resolver-tests
branch
6 times, most recently
from
2654671
to
94656da
Compare
The tests work by sending `_entities` queries with `representation` variables directly to the mocked server, which will allow us to test generated federation code end to end. For context, the format of the entity query is something like:
```
query($representations:[_Any!]!){_entities(representations:$representations){ ...on Hello{secondary} }}
```
And `representations` are the list of federated keys for the entities being resovled, and they look like
```
representations: [{
"__typename": "Hello",
"name": "federated key value 1",
}, {
"__typename": "Hello",
"name": "federated key value 2",
}]
```
The entity resolver tests are in `plugin/federation/federation_entityresolver_test.go` and they rely on `plugin/federation/testdata/entityresolver`.
To run the tests:
1. Build the entityresolver testdata
- From plugin/federation, run `go run github.com/99designs/gqlgen --config testdata/entityresolver/gqlgen.yml`
2. Run the tests with `go test ./...` or similar
MiguelCastillo
force-pushed
the
entity-resolver-tests
branch
from
94656da
to
bc3ac51
Compare
|
Something weird about how the coverage decreased with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests work by sending
_entitiesqueries withrepresentationvariables directly to the mocked server, which will allow us to test generated federation code end to end. For context, the format of the entity query is something like:And
representationsare the list of federated keys for the entities being resovled, and they look likeThe entity resolver tests are in
plugin/federation/federation_entityresolver_test.goand they rely onplugin/federation/testdata/entityresolver.To run the tests:
go run github.com/99designs/gqlgen --config testdata/entityresolver/gqlgen.ymlgo test ./...or similarI have: