Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated files from test coverage #1699

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

StevenACoffman
Copy link
Collaborator

@StevenACoffman StevenACoffman commented Nov 9, 2021

We were not ignoring a number of generated files from the test coverage reports, giving a false impression of lower coverage.

Signed-off-by: Steve Coffman steve@khanacademy.org

@coveralls
Copy link

coveralls commented Nov 9, 2021

Coverage Status

Coverage increased (+16.4%) to 67.241% when pulling 9658196 on coverage_ignores_generated into 7ac988d on master.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Copy link
Collaborator

@MiguelCastillo MiguelCastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@StevenACoffman StevenACoffman merged commit 28caa6c into master Nov 9, 2021
@StevenACoffman StevenACoffman deleted the coverage_ignores_generated branch November 9, 2021 14:37
@wilhelmeek
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants