Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding entity resolver tests for errors, entities with different type… #1708

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

MiguelCastillo
Copy link
Collaborator

…s, and requires

The tests in this PR are for ensuring we get the expected errors from entity resolvers, that we also handle resolving entities where the representations are for different types, and that requires directive works correctly.

To run tests:

  1. Go to plugin/federation
  2. Generate files with go run github.com/99designs/gqlgen --config testdata/entityresolver/gqlgen.yml
  3. And run go test ./.... Verify they all pass.

Describe your PR and link to any relevant issues.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

…s, and requires

The tests in this PR are for ensuring we get the expected errors from entity resolvers, that we also handle resolving entities where the representations are for different types, and that requires directive works correctly.

To run tests:
1. Go to `plugin/federation`
2. Generate files with `go run github.com/99designs/gqlgen --config testdata/entityresolver/gqlgen.yml`
3. And run `go test ./...`.  Verify they all pass.
@coveralls
Copy link

coveralls commented Nov 12, 2021

Coverage Status

Coverage increased (+0.09%) to 67.452% when pulling 02ea591 on Khan:entity-resolver-more-tests into ed2d699 on 99designs:master.

@MiguelCastillo
Copy link
Collaborator Author

MiguelCastillo commented Nov 12, 2021

Gotta fix the test failure before merging this. Done!

@StevenACoffman StevenACoffman merged commit 80713b8 into 99designs:master Nov 12, 2021
@MiguelCastillo MiguelCastillo deleted the entity-resolver-more-tests branch November 15, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants