Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up extra return in federation generated code #1713

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Cleaning up extra return in federation generated code #1713

merged 1 commit into from
Nov 13, 2021

Commits on Nov 13, 2021

  1. Cleaning up extra return in federation generated code 

    In PR 1709, I introduced GetMany semantics for resolving federated entities.  But I left a couple of extra return statements in the generated code that are not necessary. So Im just cleaning those up here.

Also added `go:generate` in federation entity resolver tests to make it simpler to test.

To test:
```
go generate ./... && cd example/ && go generate ./... && cd ..
go test -race ./... && cd example && go test -race ./... && cd ..
```
    @MiguelCastillo
    MiguelCastillo committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    afc01cc View commit details
    Browse the repository at this point in the history