Downgrade to Go 1.16 #1743
Merged
Downgrade to Go 1.16 #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenACoffman
force-pushed
the
go_back_1_16
branch
from
fcddbf2
to
ee41c2f
Compare
Signed-off-by: Steve Coffman <steve@khanacademy.org>
StevenACoffman
force-pushed
the
go_back_1_16
branch
from
ee41c2f
to
c08f458
Compare
|
ah good idea. I think there are some things to work out in terms of process of which versions we support and when to update go.mod. But I think 1.16 is a good starting point. This will happily make it better for us to start moving away from our own Khan Academy fork. Im happy to merge and if others have objections or thoughts we can easily adjust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need any Go 1.17 features, so moving the minimum requirement down to Go 1.16.
Signed-off-by: Steve Coffman steve@khanacademy.org