Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate playgrounds to GraphiQL #1751

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

kirkbyo
Copy link
Contributor

@kirkbyo kirkbyo commented Dec 23, 2021

Closes #1367

This PR migrates the default Playground to GraphiQL since graphql-playground is being deprecated.

How I tested this PR:

  • Ran the dataloader example to ensure that queries were still functioning.
  • Ran the chat example to ensure that mutations + WS subscriptions were still functioning.

@coveralls
Copy link

coveralls commented Jan 3, 2022

Coverage Status

Coverage increased (+0.06%) to 70.746% when pulling db00b2f on kirkbyo:graphiql-playground into 27a2b21 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 57664bf into 99designs:master Jan 14, 2022
@kirkbyo kirkbyo deleted the graphiql-playground branch January 18, 2022 17:21
Copy link

@LouisAldorio LouisAldorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, Graphql Playground is better than this GraphiQl stuff, It is better to stay in GraphQl Playground.

GraphQL Playground uses components of GraphiQL under the hood but is meant as a more powerful GraphQL IDE enabling better (local) development workflows. Compared to GraphiQL, the GraphQL Playground ships with the following additional features: Interactive, multi-column schema documentation.

@giautm
Copy link
Contributor

giautm commented Jan 21, 2022

Another thing is GraphQL Playground support multi-tabs

@Jonsy13
Copy link

Jonsy13 commented Jan 22, 2022

We had our subscriptions created based on v0.14.0, After upgrading to v0.15.0, They are not working.
Please let us know if we have to make any changes/migration for the same.
Queries & Mutations are working fine.
Thank you!

@StevenACoffman
Copy link
Collaborator

My understanding is that newer versions of GraphiQL will have feature parity with GraphQL Playground: https://graphql.org/blog/2020-04-03-web-based-graphql-ides-for-the-win/#the-playground-features-you-love

@StevenACoffman
Copy link
Collaborator

@Jonsy13 Can you make an issue describing what has broken for your subscriptions? If you are able to make a minimal open source repository that reproduces your issue, it would greatly facilitate fixing it.

@giautm
Copy link
Contributor

giautm commented Jan 23, 2022

My understanding is that newer versions of GraphiQL will have feature parity with GraphQL Playground: https://graphql.org/blog/2020-04-03-web-based-graphql-ides-for-the-win/#the-playground-features-you-love

But GraphiQL still has not released any 2.x version (even beta/alpha release), we should revert this and wait until GraphiQL is better?

@StevenACoffman
Copy link
Collaborator

I'm not opposed to that, but can you enumerate the tracking issues so we would know when "enough" GraphQL playground features have landed into GraphiQL? I see a smattering here https://github.com/orgs/graphql/projects/1/views/1

@ippsav
Copy link

ippsav commented Jan 27, 2022

It doesn t even support Dark mode.

@frederikhors
Copy link
Collaborator

People, please stop complaining.

We are not talking about something fundamental. Open playground executable if you are really interested or use Insomnia or Postman.

Luckily we have people dedicated to this project, just thank these people!

I would completely remove the playground if it were up to me. We do not need it in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GraphiQL from Playground
8 participants