Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1765: Sometimes module info not exists or not loaded. #1767

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Fix #1765: Sometimes module info not exists or not loaded. #1767

merged 2 commits into from
Jan 16, 2022

Conversation

ipfans
Copy link
Contributor

@ipfans ipfans commented Jan 16, 2022

Fix #1765.

@StevenACoffman but I think this maybe need some discussion. I have two ways to fix this: remove module info checks or just call packages.Load() twice. Both can solve this issue. But I prefer the this one.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Jan 16, 2022

Some failing tests:

--- FAIL: TestAutobinding (0.20s)
    --- FAIL: TestAutobinding/with_file_path (0.03s)
        config_test.go:211: 
            	Error Trace:	config_test.go:211
            	Error:      	An error is expected but got nil.
            	Test:       	TestAutobinding/with_file_path

@ipfans
Copy link
Contributor Author

ipfans commented Jan 16, 2022

Yeah, I see. I will updated later.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 70.685% when pulling 7a75e2d on ipfans:master into 99be195 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Jan 16, 2022

I removed the failing test for now, but I would have preferred to instead to have replaced it, perhaps with a test for #1763
So if you are able, I would love to merge that as a separate PR, but want to unbreak people ASAP.

@StevenACoffman StevenACoffman merged commit 2b8f50b into 99designs:master Jan 16, 2022
@ipfans ipfans mentioned this pull request Jan 18, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants