Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imporve gqlgen test cases #1773

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Imporve gqlgen test cases #1773

merged 2 commits into from
Jan 19, 2022

Conversation

ipfans
Copy link
Contributor

@ipfans ipfans commented Jan 17, 2022 •
edited
Loading

#1762 needs to import extras, I think no need to contains in test cases.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage increased (+4.3%) to 74.997% when pulling b8c3cc6 on ipfans:master into 7102a36 on 99designs:master.

StevenACoffman
StevenACoffman approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@StevenACoffman StevenACoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

@StevenACoffman StevenACoffman merged commit 9866507 into 99designs:master Jan 19, 2022
@mtibben mtibben mentioned this pull request Mar 1, 2022
Closed
@StevenACoffman StevenACoffman mentioned this pull request Jan 24, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenACoffman StevenACoffman StevenACoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipfans @coveralls @StevenACoffman