Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in dataloader code sample #1954

Merged
merged 2 commits into from
Feb 8, 2022
Merged

fix: typo in dataloader code sample #1954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8ff6b
fix: typo in dataloader code sample
plog3050 Feb 8, 2022
a6a1206
rename k to key for sample to compile
plog3050 Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/reference/dataloaders.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ type UserReader struct {
func (u *UserReader) GetUsers(ctx context.Context, keys dataloader.Keys) []*dataloader.Result {
// read all requested users in a single query
userIDs := make([]string, len(keys))
for ix, k := range keys {
for ix, key := range keys {
userIDs[ix] = key.String()
}
res := u.db.Exec(
Expand Down Expand Up @@ -140,7 +140,7 @@ func NewLoaders(conn *sql.DB) *Loaders {
func Middleware(loaders *Loaders, next http.Handler) http.Handler {
// return a middleware that injects the loader to the request context
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
nextCtx := context.WithValue(r.Context(), loadersKey, loader)
nextCtx := context.WithValue(r.Context(), loadersKey, loaders)
r = r.WithContext(nextCtx)
next.ServeHTTP(w, r)
})
Expand Down