Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup main #1958

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Cleanup main #1958

merged 1 commit into from
Feb 9, 2022

Conversation

mtibben
Copy link
Member

@mtibben mtibben commented Feb 9, 2022

It's simpler to navigate code for the main executable when it's in one file

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 74.363% when pulling be16474 on cleanup-main into 56bfb18 on master.

@mtibben mtibben merged commit d7da5b0 into master Feb 9, 2022
@mtibben mtibben deleted the cleanup-main branch February 9, 2022 02:09
@skaji
Copy link
Contributor

skaji commented Mar 2, 2022

FYI: As a workaround for #1483, I have

 import _ "github.com/99designs/gqlgen/cmd"

in my go project. This PR broke this use case.

@mtibben
Copy link
Member Author

mtibben commented Mar 2, 2022

This comment has the real solution #1483 (comment)

@skaji
Copy link
Contributor

skaji commented Mar 2, 2022

I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtibben @coveralls @skaji