New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Socket initialization message timeout #2006

Merged

StevenACoffman merged 2 commits into 99designs:master from RobinCPel:ws-init-timeout

Feb 28, 2022

Contributor

RobinCPel commented Feb 28, 2022

Adds an optional timeout to the web socket initialization message read operation.

This way, clients cannot occupy connections that are not ready to be used until the earth dries out! ✨

I have:

Added tests covering the bug / feature (see testing)

Not needed:

Updated any relevant documentation (see docs)

RobinCPel added 2 commits

February 28, 2022 16:29


          Added an optional timeout to the web socket initialization message re…

adf73ea

…ad operation.


          Added a fail message to a web socket init read timeout test.

d37940d

coveralls commented Feb 28, 2022

Coverage increased (+0.01%) to 74.39% when pulling d37940d on RobinCPel:ws-init-timeout into f17ca15 on 99designs:master.

StevenACoffman merged commit 9546de2 into 99designs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet