Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update quickstart" #2014

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

mtibben
Copy link
Member

@mtibben mtibben commented Mar 1, 2022

Reverts #1850 as the original issue #1849 can no longer be reproduced on master (see #1849 (comment) and #2010 (comment))

@mtibben
Copy link
Member Author

mtibben commented Mar 1, 2022

May be worth waiting until just before a release before merging, as v0.16.0 still has this issue and the README on master is what many will use

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Mar 1, 2022

When following the directions, users got an error because gqlgen cannot autobind to an empty models directory.
The workaround was to either comment out autobind in the config or put an empty model file in there. We did both, which is like wearing both a belt and braces (suspenders / サスペンダ ?). Reverting the prtinf in the directions is fine as long as the autobind config is still commented out.

@Code-Hex
Copy link
Contributor

Code-Hex commented Mar 1, 2022

off topic

Yes, right "サスペンダー" == suspenders in Japanese.

suspenders / サスペンダ ?

Today I learned phrase like "wear both a belt and braces". means "being careful". we can translate to Japanese phrase「石橋を叩いて渡る」

Thanks

@StevenACoffman StevenACoffman merged commit 082bbff into master Mar 2, 2022
@StevenACoffman StevenACoffman deleted the revert-1850-gh-quickstart branch March 2, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants