Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed modelgen test schema #2032

Merged

Conversation

Code-Hex
Copy link
Contributor

@Code-Hex Code-Hex commented Mar 3, 2022

fixed for vektah/gqlparser#202

If we don't merge this fix, tests will fail in the future because of the PR

--- FAIL: TestModelGeneration (0.00s)
    models_test.go:22:
                Error Trace:    models_test.go:22
                Error:          Received unexpected error:
                                testdata/schema.graphql:129: Type CDImplemented must implement A because it is implemented by C
                Test:           TestModelGeneration
FAIL
FAIL    github.com/99designs/gqlgen/plugin/modelgen     0.121s

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.493% when pulling 4cabaf4 on Code-Hex:fix/model-gen-implements-test into d873ff8 on 99designs:master.

@StevenACoffman StevenACoffman merged commit f85d59d into 99designs:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants