Support @skip and @include directives #208
Conversation
| panic(err) | ||
| } | ||
| ret, ok := value.(bool) | ||
| if !ok { |
There was a problem hiding this comment.
@vektah I noticed this panics when a variable is omitted from the query altogether. "Invalid" values like strings/numbers seem to get coerced into a bool. But there's probably somewhere better to report on missing variables?
There was a problem hiding this comment.
Yeah, theres a post-validation step thats still missing. Ill add a card and make sure its covered before we 
codegen/templates/object.gotpl
Outdated
| @@ -25,7 +26,8 @@ func (ec *executionContext) _{{$object.GQLType}}(ctx context.Context, sel ast.Se | |||
| } | |||
| {{- else }} | |||
| func (ec *executionContext) _{{$object.GQLType}}(ctx context.Context, sel ast.SelectionSet{{if not $object.Root}}, obj *{{$object.FullName}} {{end}}) graphql.Marshaler { | |||
| fields := graphql.CollectFields(ec.Doc, sel, {{$object.GQLType|lcFirst}}Implementors, ec.Variables) | |||
| reqCtx := graphql.GetRequestContext(ctx) | |||
| fields := graphql.CollectFields(reqCtx, sel, {{$object.GQLType|lcFirst}}Implementors) | |||
| @@ -51,23 +54,25 @@ func collectFields(doc *ast.QueryDocument, selSet ast.SelectionSet, satisfies [] | |||
|
|
|||
| f.Selections = append(f.Selections, sel.SelectionSet...) | |||
| case *ast.InlineFragment: | |||
| if !instanceOf(sel.TypeCondition, satisfies) { | |||
| if !shouldIncludeNode(sel.Directives, reqCtx.Variables) || !instanceOf(sel.TypeCondition, satisfies) { | |||
There was a problem hiding this comment.
I might be wrong, but when I did this, reqCtx had no default arguments (ones from document). So this query
query MyAwesomeQuery($shouldIncludeField: Boolean = false) {
resolver @include(if: $shouldIncludeField) {
__typename
}
}would still include in case no variables were explicitly passed. That's why I did this:
https://github.com/vektah/gqlgen/pull/187/files#diff-47a8f73d5b7f0dbad02ee4611bbedb10R79
BUT again, I might be very-very wrong.
There was a problem hiding this comment.
👍 it's probably worth a testcase
This is a snowflake implementation for skip/include directives based on the graphql-js implementation. Skip takes precedence here.
Adds a set of test cases for skip and include directives to the todo example. Also now conforms to spec if both are included.
mathewbyrne
force-pushed
the
directives-skip-include
branch
from
939e1bb
to
5d386d9
Compare
mathewbyrne
force-pushed
the
directives-skip-include
branch
from
5d386d9
to
c7ff320
Compare
Internally it can still get to RequestContext as required.
Adds support for
@skipand@includedirectives. These should function according to the specification and skip or include fields, fragments, and inline fragments.This change also includes passing the request context through to
CollectFields.See #156
Also thanks to @sergeyvlakh for his PRs #187 and #130