Add AllowedMethods field to transport.Options #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable users to specify allowed HTTP methods.
morikuni
force-pushed
the
options-allow-header
branch
from
4d92788
to
596b8a0
Compare
giautm
reviewed
Apr 6, 2022
Co-authored-by: Giau. Tran Minh <giau.tmg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to specify allowed HTTP methods in
transport.Optionsstruct.If the server didn't support querying with GET method, OPTIONS method shouldn't respond with
Allow: GET, ...header. The newly addedAllowedMethodfield enables the server to set correct allowed methods.I have: