Update module mitchellh/mapstructure to 1.5.0

[StevenACoffman]

Updating all module dependencies to the latest version causes a few WebSocket tests to fail. I wonder if @telemenar or @RobinCPel knows why updating mitchellh/mapstructure to 1.5.0 seems to break them.

The mapstructure package can be updated to v1.3.1, any other version - from v1.3.2 and up - seems to break the test...

Signed-off-by: Steve Coffman steve@khanacademy.org

[StevenACoffman]

@wilhelmeek If you have a chance to look at this, you have more experience with this than I do.

[RobinCPel]

If I update all of the go mods except for github.com/mitchellh/mapstructure, go test -race ./... succeeds. But when I update it as well, the test fails. 🤔

After some more trial-and-error: The mapstructure package can be updated to v1.3.1, any other version - from v1.3.2 and up - seems to break the test...

For reference: mapstructure's changelog.

[StevenACoffman]

Thanks to @RobinCPel I was able to upgrade the rest and merged that as a separate PR, and I rebased this so it just shows the specific problem with this one library version. I'm not able to spend more time digging into what needs to change, but we'll need to wrestle with this eventually.

[ubiuser]

I hope this helps to find the answer: mitchellh/mapstructure#290

[coveralls]

Coverage decreased (-0.006%) to 75.458% when pulling 9fd55d1 on update_modules into ea9590a on master.

[StevenACoffman]

It looks like we were always taking the pointer of a pointer in the websocket code, and somehow this worked ok in the old mapstructure, but not in the newer versions.

gqlgen/client/websocket.go

Line 55 in 9fd55d1

return sock.Next(&resp)

Special thanks to @jakezhu9 and @ubiuser who helped figure this out in mitchellh/mapstructure#290 (comment)