Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevents goroutine leak at websocket transport #2167 #2168

Merged
merged 1 commit into from
May 14, 2022
Merged

fix: prevents goroutine leak at websocket transport #2167 #2168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions graphql/handler/transport/websocket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,12 +371,20 @@ func (c *wsConnection) subscribe(start time.Time, msg *message) {

responses, ctx := c.exec.DispatchOperation(ctx, rc)
for {
response := responses(ctx)
if response == nil {
break
}
// prevents goroutine leak
select {
case <-ctx.Done():
return
default:
{
response := responses(ctx)
if response == nil {
break
}

c.sendResponse(msg.id, response)
c.sendResponse(msg.id, response)
}
}
}

// complete and context cancel comes from the defer
Expand Down