Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2204 - don't try to embed builtin sources #2214

Merged
merged 4 commits into from
May 26, 2022

Conversation

vikstrous
Copy link
Contributor

There was a bug introduced in #2119 that led to us trying to "embed" files that don't exist because they are "builtin" graphql schema files. This makes sure that those files are never embedded. This fixes fix #2204

I have:

  • Added tests covering the bug / feature (see testing)
  • [n/a] Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented May 26, 2022

Coverage Status

Coverage decreased (-0.05%) to 74.944% when pulling 591ba1f on vikstrous:fix-federation into 8d9d3f1 on 99designs:master.

@vikstrous vikstrous marked this pull request as ready for review May 26, 2022 14:39
@StevenACoffman
Copy link
Collaborator

Thanks for the quick turn around!

@StevenACoffman StevenACoffman merged commit 5f5bfcb into 99designs:master May 26, 2022
@StevenACoffman
Copy link
Collaborator

Released in v0.17.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed generation with plugins fails
3 participants