Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploads currently expose their content as an
io.Reader
, which makes it hard to read their content multiple times.The content is either backed by an
os.File
which is seekable or abytesReader
(in-memory buffer) which can be trivially made seekable.This PR makes
bytesReader
implement theio.Seeker
interface and changes the type of the fieldFile
inUpload
toio.ReadSeeker
to allow consumers to simply callSeek
on the upload's content.The
prevRune
field has also been removed frombytesReader
since it was unused.I have: