github: Fix CI pipelines #2266
github: Fix CI pipelines #2266
Conversation
.github/workflows/integration.yml
Outdated
| go-version: ${{ matrix.go }} | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 14 |
There was a problem hiding this comment.
Can we make this a root env variable so we can only maintain it in one place?
.github/workflows/integration.yml
Outdated
| jobs: | ||
| integration: | ||
| strategy: | ||
| matrix: | ||
| go: [1.16, 1.17, 1.18] |
There was a problem hiding this comment.
Testing on all three versions will take longer and cost more. Do you think passing on Go 1.16 is likely to fail on Go 1.17 or Go 1.18?
There was a problem hiding this comment.
I thought GitHub was pretty generous with the open source use of github actions.
There was a problem hiding this comment.
99designs has exceeded the free tier, but it's unclear to me as an external maintainer to how much this repository contributed to that usage, compared to their other open source repositories, or their private GitHub action usage. Since it's not my money, I try to only use what I need. I think your revision where you are testing oldest supported (Go 1.16) and newest supported (Go 1.18) is a great compromise. Thanks!
There was a problem hiding this comment.
I would prefer the last 2 versions of Go, to align with the Go EOL policy
There was a problem hiding this comment.
@mtibben I agree with you that is the goal, but we at Khan are using Go 1.16 until GCP AppEngine supports a newer Go version, and I can't help maintain this project if it is beyond that. GCP tells us they plan on skipping Go 1.17 and releasing support for Go 1.18 in H2 of 2022 (so July-Dec 2022) but haven't increased that. As a result, we previously agreed to keep gqlgen supporting the same Go version as Khan uses in prod (and newer).
tmc
force-pushed
the
tmc-fix-ci
branch
2 times, most recently
from
14bbb18
to
0bd22d1
Compare
tmc
force-pushed
the
tmc-fix-ci
branch
2 times, most recently
from
ff72646
to
9644f56
Compare
|
This is great! Thanks so much for helping to avoid the flaky failures we've been experiencing! |
This fixes the CI pipelines:
This modernizes the workflows uses a curl retry to wait for the servers being up.