codegen: fix the run order of resolvers #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
changed the title
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
|
Hello @StevenACoffman, please review this PR. I have added tests and updated the template to generate the input resolver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (entgql) have a report from @amrnt about the unexpected result when he want to trying to use the custom Input field to set the value for the mutation's input.
Because with
rangethe order of the map's iteration is randomized, so the custom field may run first then overrided by the original input.You can run the test here few times without cache: ent/contrib@master...amrnt:contrib:custom-input-field
I have: