Hide github.com/matryer/moq dependency in tools.go from importers
#2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects that use `go mod vendor` will vendor `github.com/matryer/moq` despite it not being required at runtime. Moving `tools.go` to `internal` hides this import from downstream users and avoids `github.com/matryer/moq` being vendored. `go generate` of the mocks still works as expected. The assumption behind the import test broke, so I've pointed it at a different path that has no Go code. This seems to match the intent behind the original test for the `internal/code/..` path.
danielwhite
force-pushed
the
hide-moq-dependency
branch
from
d62e44c
to
a4defc3
Compare
danielwhite
commented
Jul 12, 2022
| @@ -40,6 +40,6 @@ func TestNameForDir(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, "tmp", NameForDir("/tmp")) | |||
| assert.Equal(t, "code", NameForDir(wd)) | |||
| assert.Equal(t, "internal", NameForDir(wd+"/..")) | |||
There was a problem hiding this comment.
Apologies for failing to sanity check the tests initially.
Turns out that the assumption behind the this assertion broke due to moving tools.go. I've pointed it at a different path that has no Go code. This seems to match the intent behind the original test for the internal/code/.. path.
I may have misunderstood, so happy for alternative suggestions. 🤔
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have project(s) that use
go mod vendor. Currently,github.com/matryer/moqis vendored despite it not being required at runtime.Moving
tools.gotointernalhides this import from downstream users and avoidsgithub.com/matryer/moqbeing vendored.go generateof the mocks still works as expected.I have:
Added tests covering the bug / feature (see testing)Updated any relevant documentation (see docs)