Hide github.com/matryer/moq
dependency in tools.go
from importers
#2287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have project(s) that use
go mod vendor
. Currently,github.com/matryer/moq
is vendored despite it not being required at runtime.Moving
tools.go
tointernal
hides this import from downstream users and avoidsgithub.com/matryer/moq
being vendored.go generate
of the mocks still works as expected.I have:
Added tests covering the bug / feature (see testing)Updated any relevant documentation (see docs)