Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omit_getters config option #2348

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add omit_getters config option #2348

merged 1 commit into from
Aug 29, 2022

Conversation

neptoess
Copy link
Contributor

As discussed in #2331 with @StevenACoffman and @MichaelMure , adding a config option to disable getter generation for interface types

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 75.488% when pulling b798454 on neptoess:getter-gen-flag into 2ba8040 on 99designs:master.

Copy link
Contributor

@MichaelMure MichaelMure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a gqlgen outsider, that seems reasonable. Thanks!

@StevenACoffman StevenACoffman merged commit b66fff1 into 99designs:master Aug 29, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

@MichaelMure
Copy link
Contributor

I can confirm that it worked for me. However, that option is not documented on the website, it might make sense to do so.

@neptoess
Copy link
Contributor Author

I added it as the last question in the FAQ section of the README

@MichaelMure
Copy link
Contributor

Arguably, I'd expect all the possible options to show up at https://gqlgen.com/config/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants