Add json.Number support to UnmarshalString #2396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnmarshalString
currently supports most basic types (string
,int
,float64
, ...), but notjson.Number
, which is used when decoding float values from JSON.This PR:
json.Number
support toUnmarshalString
graphql.UnmarshalString
tests which were missinggraphql.UnmarshalString
withfloat64
inputs to output a string with the smallest number of digits necessary (graphql.UnmarshalString(float64(123))
will output"123"
instead of"123.000000"
)The last change while not strictly necessary seemed to make more sense when I was writing the tests. I made it in a separate commit so it can be easily discarded.
I have: