Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use goField directive for getters generation #2447

Merged
merged 2 commits into from
Dec 3, 2022
Merged

use goField directive for getters generation #2447

merged 2 commits into from
Dec 3, 2022

Conversation

StevenACoffman
Copy link
Collaborator

Fixes #2439, reformats #2440

When you have an interface and override generated models fields name with goField directive. This PR makes it so getters generated by gqlgen will access field values using the field that was specified in the goField directive.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

darkLord19 and others added 2 commits November 29, 2022 00:38
@StevenACoffman
Copy link
Collaborator Author

@darkLord19 I reformatted your PR to pass linting, so I'm going to merge this PR, rather than your original PR, since I can't push to yours.

@StevenACoffman StevenACoffman merged commit 5c083c7 into master Dec 3, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.636% when pulling de30b20 on 2440 into 463d213 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface getters are not using goField directive
3 participants