use json.Decoder.UseNumber() when unmarshalling vars #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
use json.Decoder.UseNumber() when unmarshalling vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new stricter variable validation rules uncovered a bug where json unmarshalling ints would get converted to floats, then coerced back to ints.
This is obviously a lossy process for large int numbers (52 bit mantissa means numbers up to 4,503,599,627,370,496 should be OK).
I've removed the coercion from float -> int and opted into json.Decoder.UseNumber which keeps all numbers as strings until we go to decode them, giving us back the full 64 bits.