Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup only non-gqlgen packages when reloading all packages #2598

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Cleanup only non-gqlgen packages when reloading all packages #2598

merged 1 commit into from
Apr 7, 2023

Conversation

AdallomRoy
Copy link
Contributor

@AdallomRoy AdallomRoy commented Mar 28, 2023 •
edited
Loading

Describe your PR and link to any relevant issues.

This is a minor performance improvement. When reloading packages, there is no need to reload gqlgen packages as they surely haven't changed, only user packages.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Mar 29, 2023 •
edited
Loading

Coverage Status

Coverage: 78.56% (+2.7%) from 75.892% when pulling 7857dfe on AdallomRoy:master into a1a6f23 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

thanks! Hey, can you gofmt -s the file?

@AdallomRoy
Copy link
Contributor Author

Done

@StevenACoffman StevenACoffman merged commit 21054eb into 99designs:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdallomRoy @coveralls @StevenACoffman