Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip federation2 directives generation #2699

Closed
wants to merge 1 commit into from

Conversation

rlch
Copy link

@rlch rlch commented Jun 28, 2023

This PR excludes the federation 2 directives added in #2635 from being added to DirectiveRoot. Without this exclusion, usage of @interfaceObject or @composeDirective fails at runtime with something like:

{
  "data": null,
  "errors": [
    {
      "message": "directive interfaceObject is not implemented",
      "path": [
        "startTest",
        "currentQuestion"
      ]
    }
  ],
  "extensions": {
    "valueCompletion": [
      {
        "message": "Cannot return null for non-nullable field Mutation.startTest",
        "path": []
      }
    ]
  }
}

Please let me know if there's anything to do for this PR. I couldn't find documentation on how to regenerate testdata/, unsure if go generate ./... was sufficient. Thanks for reviewing + for this great package (and hello from Melbourne)!

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Jul 5, 2023

Coverage Status

coverage: 75.418% (-3.8%) from 79.196% when pulling cb497f2 on rlch:master into 470fca8 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Please do this:

go generate ./...; cd _examples; go generate ./...

@dariuszkuc
Copy link
Contributor

looks like this was merged in #2821, should this be closed?

@StevenACoffman
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants