fix: Skip federation2 directives generation #2699
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes the federation 2 directives added in #2635 from being added to
DirectiveRoot
. Without this exclusion, usage of@interfaceObject
or@composeDirective
fails at runtime with something like:Please let me know if there's anything to do for this PR. I couldn't find documentation on how to regenerate
testdata/
, unsure ifgo generate ./...
was sufficient. Thanks for reviewing + for this great package (and hello from Melbourne)!I have: