Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cache generic to avoid casting #3179

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Make cache generic to avoid casting #3179

merged 2 commits into from
Jul 12, 2024

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Jul 11, 2024

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@sylr
Make cache generic to avoid casting
31fc29f 
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@coveralls
Copy link

coveralls commented Jul 12, 2024 •
edited
Loading

Coverage Status

coverage: 74.637%. remained the same
when pulling 692df1f on sylr:generic-cache
into f2cf11e on 99designs:master.

StevenACoffman
StevenACoffman reviewed Jul 12, 2024
View reviewed changes
handler/handler.go Outdated Show resolved Hide resolved
@StevenACoffman
Copy link
Collaborator

Thanks! This is a nice change. Minor lint nit.

@StevenACoffman StevenACoffman merged commit 4d8d93c into 99designs:master Jul 12, 2024
17 checks passed
@indera indera mentioned this pull request Oct 2, 2024
Merged
2 tasks
@adomaskizogian adomaskizogian mentioned this pull request Oct 15, 2024
Closed
@StevenACoffman StevenACoffman mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenACoffman StevenACoffman StevenACoffman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sylr @coveralls @StevenACoffman