Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3203 change that added Concurrent directive for resolvers #3287

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

StevenACoffman
Copy link
Collaborator

@StevenACoffman StevenACoffman commented Sep 16, 2024

Fix #3285 by reverting #3203

The intended change may have been valuable, but it proved very disruptive (especially for data loaders).

Perhaps a directive @sequential would opt-in to a change in behavior.

Signed-off-by: Steve Coffman steve@khanacademy.org

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit f81239e into master Sep 16, 2024
17 checks passed
@StevenACoffman StevenACoffman deleted the revert_3203 branch September 16, 2024 22:23
@StevenACoffman StevenACoffman changed the title Revert 3203 Revert #3203 change that added Concurrent directive for resolvers Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataloaders broken since v0.17.50 and merge of #3203
1 participant