Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle common initialisms as the non-first word #3302

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

noamcohen97
Copy link
Contributor

If a common initialisms was the prefix of the second word (or any word other the first one) of an identifier, it was treated as initialism even though the next rune was uppercase. e.g. "USER_IDENTITY".

This PR should resolve this issue

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

noamcohen97 and others added 2 commits September 26, 2024 14:50
@StevenACoffman StevenACoffman merged commit cd6f0b9 into 99designs:master Sep 26, 2024
16 checks passed
@coveralls
Copy link

Coverage Status

coverage: 58.869%. remained the same
when pulling bbe0df8 on noamcohen97:fix_initialisms_bug
into a711ecb on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Thanks! I really appreciate the clarification in the comments and renaming of variables.

@noamcohen97 noamcohen97 deleted the fix_initialisms_bug branch September 26, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants