fix op to rc in comment of FieldContext.Child #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ichikawa
commented
Oct 17, 2024
graphql/context_field.go
Outdated
| @@ -36,8 +36,8 @@ type FieldContext struct { | |||
| // | |||
| // srv.AroundFields(func(ctx context.Context, next graphql.Resolver) (interface{}, error) { | |||
| // fc := graphql.GetFieldContext(ctx) | |||
| // op := graphql.GetOperationContext(ctx) | |||
| // collected := graphql.CollectFields(opCtx, fc.Field.Selections, []string{"User"}) | |||
| // rc := graphql.GetOperationContext(ctx) | |||
There was a problem hiding this comment.
Actually, there are some variations in the naming of the variable returned from graphql.GetOperationContext() (e.g., rc, opCtx, rctx) in gqlgen repository, but rc is the most common.
|
Hey, I appreciate making things more consistent, but it feels unintuitive for the |
s-ichikawa
force-pushed
the
fix-comment
branch
from
ee552b6 to
1db51ae
Compare
|
@StevenACoffman maybe I changed them all. |
|
Thanks so much! This has confused a number of people, so I appreciate you cleaning it up! Looking forward to future contributions from you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the implementation in the comments.
I have: