Support Extensions in Response #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewbyrne
force-pushed
the
support-response-extensions
branch
from
bc5fb3e
to
30adec3
Compare
mathewbyrne
force-pushed
the
support-response-extensions
branch
from
30adec3
to
417338f
Compare
mathewbyrne
force-pushed
the
support-response-extensions
branch
from
417338f
to
8fdf4fb
Compare
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
…nsions Support Extensions in Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphQL spec allows for an
extensionskey to be provided in responses to allow the server to extend responses however they see fit.This change adds support for this key in responses, and allows code with access to the
RequestContextto add values to this map using theRegisterExtensionmethod. The intended usage is for aRequestMiddlewareto register a value once, either at the start of a request and pass the value around, or at the end of a request. An error will be returned if a key is registered twice.The current primary use-case for this is Apollo Tracing (#219) — which this PR will assist with.