Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing boundary when MultipartMixed transport aggregates initial and deferred response #3382

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

phughes-scwx
Copy link
Contributor

Adds an additional test to the MultipartMixed transport that triggers aggregation between the initial and a deferred response. Patches the writer to ensure in this case that an extra boundary is written between the two parts.

See the issue details here: #3381 .

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs) (n/a)

@coveralls
Copy link

coveralls commented Nov 21, 2024

Coverage Status

coverage: 59.614% (+0.01%) from 59.601%
when pulling 8b8e52a on phughes-scwx:issue-3381
into 1040b92 on 99designs:master.

@phughes-scwx
Copy link
Contributor Author

@StevenACoffman @rmennes FYI

@StevenACoffman StevenACoffman merged commit 0d2ba68 into 99designs:master Nov 22, 2024
16 of 17 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks! Yeah, @defer support could use more thorough testing and verification.

@phughes-scwx phughes-scwx deleted the issue-3381 branch November 22, 2024 16:31
@StevenACoffman StevenACoffman added the defer-or-stream Related to GraphQL @defer or @stream directives label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer-or-stream Related to GraphQL @defer or @stream directives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants