added support for use_function_syntax_for_execution_context #3407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened?
With very large type systems gqlgen can generate code that can no longer by compiled by the go compiler. Once more than 65.000 methods have been added to the executionContext the Go compiler fails with:
<autogenerated>:1: internal compiler error: too many methods on *executionContext: <some number>
Proposed Solution
Generate regular functions instead of receiver methods of
*executionContext
and pass*executionContext
as function argument controlled by config -use_function_syntax_for_execution_context
Addressing this issue - #2681