Underscore on field name finder #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-brito
force-pushed
the
fix-underscore
branch
from
e18c9f1
to
8975812
Compare
vektah
requested changes
Oct 10, 2018
codegen/util.go
Outdated
| @@ -105,6 +105,12 @@ func findMethod(typ *types.Named, name string) *types.Func { | |||
| return nil | |||
| } | |||
|
|
|||
| func equalFold(source, target string) bool { | |||
There was a problem hiding this comment.
This isn't equal fold any more, the name isn't great.
If its only called from findField, maybe equalFieldName?
rodrigo-brito
force-pushed
the
fix-underscore
branch
from
8975812
to
0ad3d3c
Compare
|
Fixed! |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Underscore on field name finder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema fields with underscore are not considered on finder field. The
strings.EqualFolddon't consider the underscore on compare operation.Closes #357
I have: