Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type binding validation for slices of pointers like []*foo #439

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Fix type binding validation for slices of pointers like []*foo #439

merged 1 commit into from
Nov 26, 2018

Conversation

snormore
Copy link
Contributor

I was running into this during gqlgen -v:

field has wrong type: []github.com/snormore/foobar/pkg/app.Foo is not compatible with []*github.com/snormore/foobar/pkg/app.Foo

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@snormore
Copy link
Contributor Author

cc @vektah for 👀

@vektah
Copy link
Collaborator

vektah commented Nov 26, 2018

I'm planning a refactor for this, but have been very time poor recently.

Thanks for the PR, looks good.

@vektah vektah merged commit 4b08251 into 99designs:master Nov 26, 2018
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#439 from snormore/pointer-slice
ad962c4 
Fix type binding validation for slices of pointers like []*foo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snormore @vektah