Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a benchmark for a simple query and make a 2 quick optimisations:
before
You can see
morestack
dominating the graph here (28%). This happens because we create new goroutines around every resolver, and even though go does recycle old goroutine in a pool, it doesn't maintain their stacks.after
~ 30% faster.
Ideas for future tweaks:
morestack
+ 13% in starwars.ec_Human_starship: Marshalling arrays in results also happens concurrently, theres another high fanout go func() in here. This causes lots of short lived goroutines, which allocate more stack. Probably the next target.