Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list of enums #486

Merged
merged 2 commits into from
Jan 5, 2019
Merged

Conversation

nicovogelaar
Copy link
Contributor

@nicovogelaar nicovogelaar commented Jan 3, 2019

Issue: #481

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah changed the base branch from master to next January 4, 2019 09:44
@vektah
Copy link
Collaborator

vektah commented Jan 4, 2019

Nice 👍. We do the same thing with an internal enum generator.

We are currently avoiding committing unreleased changes to master because it breaks go get based workflows that consider master stable. Could you rebase this onto the next branch please?

@nicovogelaar
Copy link
Contributor Author

thank you for this library, it's really nice. I just rebased onto the next branch. the circle ci build seems to be a bit unstable. I'm not sure how to write a good test for this.

@vektah vektah merged commit dd97208 into 99designs:next Jan 5, 2019
@vektah vektah mentioned this pull request Jan 5, 2019
@vektah vektah mentioned this pull request Mar 4, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants