Bind directly to AST types, instead of copying out random bits #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😅 This took a bit of work.
The core of this change is to go from
to
This refactor is preparing for a few upcoming changes:
This PR breaks a fairly subtle old behaviour, automatically treating wrapped scalar types as their primitives by automatically casting. This will be replaced by being able to define multiple custom scalars for the primitives, and I will make sure that lands before we tag a release.
Aside from that, pretty confident in this change. Only generated code changes were minor whitespace issues.