Model plugin #502
Merged
Model plugin #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vektah Wow this is a huge change but going to make things much simpler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes model generation to be nearly entirely independent of codegen, it only shares the config and some utils for binding to the go program.
Was going to do this much later, but pulling model generation out of codegen entirely lets us add a new constraint to the binding phase: All types have backing go implementations. This should allow us to delete a whole step (Named Type collection), removing a whole lot of indirection. Will probably roll this change into allowing multiple types as its going to be a pretty large change to the type system.
Plugin interfaces still very experimental.