Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for go modules outside of GOPATH #548

Closed
wants to merge 9 commits into from

Conversation

bheatwole
Copy link

Fixes #547

I have:

  • [*] Added tests covering the bug / feature
  • [*] Updated any relevant documentation
    The 'Getting Started' guide needed a few touch-ups to remove 'dep' and use 'go mod'

If you follow the steps in the Getting Started guide, or the Steps to Reproduce listed in #547, be aware that you will need to add the following command after running go mod init

go get github.com/99designs/gqlgen@[commit ID of this PR]

Otherwise go mod will pull in the latest release of gqlgen that doesn't have the fix! Once this PR is merged and released, that extra step should no longer be necessary.

Also I added a line to 'Getting Started' to mkdir server. If that directory did not exist, the generator would panic. I fixed it in the documentation because I wasn't sure if that was the desired behavior or if the template system should be creating the directory if it doesn't exist.

@vektah
Copy link
Collaborator

vektah commented Feb 17, 2019

Nice clean pull request, however this is already supported on the next branch, you can test it out using go get github.com/99designs/gqlgen@next.

see #514 and #226

@vektah vektah closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Fails Compile outside of GOPATH
2 participants