Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from panics in unlikly places #554

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Recover from panics in unlikly places #554

merged 1 commit into from
Feb 18, 2019

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Feb 18, 2019

There are places in the generated code that aren't covered by recovers(), this adds them around all new goroutines to make sure the server doesn't crash if a panic does happen.

Fixes #472

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah merged commit 51266b8 into next Feb 18, 2019
@vektah vektah deleted the fix-missing-recover branch February 18, 2019 06:00
@vektah vektah mentioned this pull request Mar 4, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant