Fix for @deprecated directive not working #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That line comes from when they were first added, I'm guessing what that skip actually does has changed a little. |
|
Ok, so instead of skipping these directives then, we set a flag and only include directives with the flag in the |
These have an internal implementation and should be excluded from the DirectiveRoot. In the future this may be a func that plugins could use to add custom implementations.
mathewbyrne
force-pushed
the
fix-deprecated-directive
branch
from
f8fd052
to
5ba8c8e
Compare
vektah
approved these changes
Mar 6, 2019
mathewbyrne
changed the title
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Fix for @deprecated directive not appearing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
During
buildDirectivesin codegen, the builtin directivesskip,include, anddeprecatedare skipped over. This causes them to not be registered with the builder later when building objects. It seems likedeprecatedis definitely needed, since it's a schema directive.skipandincludeI'm not so sure about. @vektah what's the reason for skipping these in build?