Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle colliding fields in complexity root gracefully #622

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Mar 14, 2019

Theres a bit of history on this one, see #376 and #473.

This PR just makes sure that if multiple complexity fields would collide that only one is added. It does mean we cant specify different complexity functions for each field, but it seems like a reasonable tradeoff.

fixes #600

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah merged commit 58744de into master Mar 14, 2019
@vektah vektah deleted the handle-complexity-root-collisions branch March 14, 2019 23:13
@vektah vektah mentioned this pull request Apr 15, 2019
2 tasks
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
…t-collisions

Handle colliding fields in complexity root gracefully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComplexityRoot in the generated file is wrong when binding to ID
2 participants