make gqlgen generate 10x faster in some projects #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
make gqlgen generate 10x faster in some projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres a horrible performance stall (~3 seconds per call) when trying to look up package data for empty directories. There must be some more conditions to it, because I don't see it when working inside gqlgen, only when using gqlgen in other apps via go modules.
Might be related to golang/go#29427, I am using protobuffers which I think has a cgo component.
In this PR I've removed x/tools/packages use when doing simple dir -> package lookups, doing the file system traversal to find a mod file in this direction is trivial.
For one of my small projects this takes the time to generate down from
25.17sto2.57sI have: