fixed generating a description to golang comments for enum type #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've created a bug fix for plugin modelgen. I and my team have recently started using the tool in production and we really like it.
I wanted to dig into the code by submitting an easy fix of something that I found out. When models are generated from GraphQL schema, a description is used as golang comments. It works fine for all GraphQL types but enum. It worked in a way that the description was formatted into a single word CamelCased. I've added test cases and fixed it by removing calling
go
in a template pipe.Those tests from me could be more sophisticated as I am checking only for the number of words in a comment.
Let me know if this is welcomed. I would like to contribute more.